Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove softplus in AmortizedLDA for cell topic variance #1445

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

justjhong
Copy link
Contributor

@justjhong justjhong commented Mar 15, 2022

Tested in Colab
image

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1445 (3ceed29) into master (14d6f6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         111      111           
  Lines        8743     8743           
=======================================
  Hits         7954     7954           
  Misses        789      789           
Impacted Files Coverage Δ
scvi/module/_amortizedlda.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d6f6f...3ceed29. Read the comment docs.

@adamgayoso adamgayoso enabled auto-merge (squash) March 15, 2022 23:10
@adamgayoso adamgayoso added this to the 0.16.0 milestone Mar 16, 2022
@adamgayoso adamgayoso merged commit d2d9f12 into master Mar 16, 2022
@adamgayoso adamgayoso deleted the jhong/iss1359 branch March 16, 2022 22:30
@adamgayoso adamgayoso removed this from the 0.16.0 milestone Mar 20, 2022
@adamgayoso
Copy link
Member

@meeseeksdev backport to 0.15.x

@adamgayoso
Copy link
Member

@meeseeksdev hello

@adamgayoso
Copy link
Member

@meeseeksdev backport 0.15.x

@Carreau
Copy link

Carreau commented Mar 20, 2022

Can you retry ? It looks like the installation on PlasmaPy was suspended and that made the whole bot crash. It should be back.

@adamgayoso
Copy link
Member

@meeseeksdev backport to 0.15.x

@adamgayoso
Copy link
Member

@Carreau Thanks!

adamgayoso pushed a commit that referenced this pull request Mar 20, 2022
…iance (#1452)

Co-authored-by: Justin Hong <jjhong922@berkeley.edu>
@Carreau
Copy link

Carreau commented Mar 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants