Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to super().__init__() #1671

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Conversation

mkarikom
Copy link
Contributor

global super().init() referenced in #1670

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 91.39% // Head: 91.39% // No change to project coverage 👍

Coverage data is based on head (0c62822) compared to base (69fc6bb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1671   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         116      116           
  Lines        9190     9190           
=======================================
  Hits         8399     8399           
  Misses        791      791           
Impacted Files Coverage Δ
scvi/external/gimvi/_model.py 92.16% <100.00%> (ø)
scvi/external/stereoscope/_model.py 94.66% <100.00%> (ø)
scvi/model/_autozi.py 98.79% <100.00%> (ø)
scvi/model/_condscvi.py 96.62% <100.00%> (ø)
scvi/model/_destvi.py 88.28% <100.00%> (ø)
scvi/model/_linear_scvi.py 100.00% <100.00%> (ø)
scvi/model/_peakvi.py 88.88% <100.00%> (ø)
scvi/model/_scanvi.py 94.48% <100.00%> (ø)
scvi/model/_scvi.py 100.00% <100.00%> (ø)
scvi/model/_totalvi.py 87.59% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkarikom
Copy link
Contributor Author

Just noticed the contributing guidelines after the docs check failed, and tried to make a release with an existing tag (0.17.1), then update the commit.

I admit that I don't really understand what Releases are and haven't made one before, lol.

@adamgayoso
Copy link
Member

Thanks, this looks good. We are having some issue with one of our tutorials that is causing the docs to fail so this might hang for a bit.

@adamgayoso adamgayoso enabled auto-merge (squash) September 14, 2022 00:28
@adamgayoso adamgayoso merged commit f4f50af into scverse:master Sep 14, 2022
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Sep 14, 2022
adamgayoso pushed a commit that referenced this pull request Sep 14, 2022
Co-authored-by: Matt Karikomi <mkarikom@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants