Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate SaveBestState #2567

Closed
wants to merge 7 commits into from
Closed

deprecate SaveBestState #2567

wants to merge 7 commits into from

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Feb 27, 2024

Users should now use scvi.train.SaveCheckpoint or the enable_checkpointing Lightning arg instead.

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (049e7eb) to head (2dd068c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   89.31%   88.81%   -0.50%     
==========================================
  Files         158      158              
  Lines       13276    13281       +5     
==========================================
- Hits        11857    11796      -61     
- Misses       1419     1485      +66     
Files Coverage Δ
scvi/model/_multivi.py 73.52% <100.00%> (+0.09%) ⬆️
scvi/model/_peakvi.py 89.34% <100.00%> (+0.26%) ⬆️
scvi/train/_callbacks.py 87.66% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@martinkim0
Copy link
Contributor Author

closing in favor of #2673

@martinkim0 martinkim0 closed this Apr 3, 2024
@martinkim0 martinkim0 deleted the deprecate-savebeststate branch April 3, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant