Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(train): deprecate savebeststate callback and save_best arg #2673

Merged
merged 4 commits into from Apr 3, 2024
Merged

chore(train): deprecate savebeststate callback and save_best arg #2673

merged 4 commits into from Apr 3, 2024

Conversation

martinkim0
Copy link
Contributor

closes #2568

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Apr 3, 2024
@martinkim0 martinkim0 mentioned this pull request Apr 3, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (85540d1) to head (9cc28ea).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2673   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         158      158           
  Lines       13235    13240    +5     
=======================================
+ Hits        11757    11762    +5     
  Misses       1478     1478
Files Coverage Δ
scvi/model/_multivi.py 73.52% <100.00%> (+0.09%) ⬆️
scvi/model/_peakvi.py 89.34% <100.00%> (+0.26%) ⬆️
scvi/train/_callbacks.py 85.27% <100.00%> (+0.11%) ⬆️

@martinkim0 martinkim0 merged commit ce1f955 into main Apr 3, 2024
12 checks passed
@martinkim0 martinkim0 deleted the deprecate branch April 3, 2024 01:40
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Apr 3, 2024
@martinkim0 @meeseeksmachine
Backport PR scverse#2673: chore(train): deprecate savebeststate callb…
dbe68e1 
…ack and save_best arg
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 3, 2024
Merged
martinkim0 added a commit that referenced this pull request Apr 3, 2024
@meeseeksmachine @martinkim0
Backport PR #2673 on branch 1.2.x (chore(train): deprecate savebestst…
6dd31aa 
…ate callback and save_best arg) (#2674)

Backport PR #2673: chore(train): deprecate savebeststate callback and
save_best arg

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate scvi.train.SaveBestState and save_best argument
1 participant
@martinkim0