Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored transformations implementation #162

Merged
merged 8 commits into from
Oct 13, 2023

Conversation

timtreis
Copy link
Member

@timtreis timtreis commented Sep 5, 2023

Now using the get_extent functionality from spatialdata. Also, all transformations are now being applied using matplotlib.

@timtreis timtreis changed the title Refactored transformations implementation [BLOCKED] Refactored transformations implementation Sep 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #162 (c85cc15) into main (4fc2b04) will decrease coverage by 1.95%.
The diff coverage is 75.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   79.03%   77.09%   -1.95%     
==========================================
  Files          11       11              
  Lines        1345     1196     -149     
==========================================
- Hits         1063      922     -141     
+ Misses        282      274       -8     
Files Coverage Δ
src/spatialdata_plot/pl/render.py 88.51% <97.61%> (-0.87%) ⬇️
src/spatialdata_plot/pl/basic.py 85.87% <84.61%> (+0.24%) ⬆️
src/spatialdata_plot/pl/utils.py 59.86% <31.25%> (-9.06%) ⬇️

@timtreis timtreis changed the title [BLOCKED] Refactored transformations implementation Refactored transformations implementation Oct 13, 2023
@timtreis timtreis merged commit c1cc849 into main Oct 13, 2023
6 checks passed
@timtreis timtreis deleted the bugfix/103-wrong-spatialplot-of-affine-transformation branch October 13, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation and Scale fail when not all the axes are specified Wrong spatialplot of Affine Transformation
3 participants