Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiscaleImage handling #164

Merged
merged 34 commits into from
Nov 27, 2023
Merged

Conversation

Sonja-Stockhaus
Copy link
Collaborator

@Sonja-Stockhaus Sonja-Stockhaus commented Sep 27, 2023

The user can either select a scale or the multi-scale images to be rendered are rasterized before

@timtreis, 2023-10-16: "Please also provide the first (pre-datashader) version of this notebook: scverse/spatialdata-notebooks#59 "

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Sep 27, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #164 (0fa93fa) into main (3e09dd1) will increase coverage by 0.86%.
The diff coverage is 89.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   77.09%   77.95%   +0.86%     
==========================================
  Files          11       11              
  Lines        1196     1293      +97     
==========================================
+ Hits          922     1008      +86     
- Misses        274      285      +11     
Files Coverage Δ
src/spatialdata_plot/pl/basic.py 87.68% <100.00%> (+1.80%) ⬆️
src/spatialdata_plot/pl/render.py 88.84% <100.00%> (+0.33%) ⬆️
src/spatialdata_plot/pl/render_params.py 100.00% <100.00%> (ø)
src/spatialdata_plot/pl/utils.py 62.52% <80.00%> (+2.65%) ⬆️

@timtreis timtreis marked this pull request as ready for review October 16, 2023 15:10
Copy link
Member

@timtreis timtreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Cover usecase in which I plot a list of elements and pass a list to scale, elementwise matching
  • Implement logic which decouples img-raster DPI from canvas size DPI as discussed

src/spatialdata_plot/pl/utils.py Outdated Show resolved Hide resolved
src/spatialdata_plot/pl/render.py Outdated Show resolved Hide resolved
@LucaMarconato
Copy link
Member

Just a quick comment, I have been using this new branch, works super smooth! Great work!

@timtreis timtreis merged commit c10b177 into main Nov 27, 2023
6 checks passed
@timtreis timtreis deleted the feature/issue96-plot-multiscale-images branch November 27, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants