Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for stacking of render commands #192

Conversation

timtreis
Copy link
Member

@timtreis timtreis commented Dec 8, 2023

Based on: #190

@timtreis timtreis linked an issue Dec 8, 2023 that may be closed by this pull request
@timtreis timtreis self-assigned this Dec 8, 2023
@timtreis timtreis added the enhancement New feature or request label Dec 8, 2023
@timtreis timtreis added this to the v0.1.0 release milestone Dec 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Merging #192 (91f810d) into main (74afb01) will increase coverage by 0.11%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   77.94%   78.06%   +0.11%     
==========================================
  Files          11       11              
  Lines        1297     1304       +7     
==========================================
+ Hits         1011     1018       +7     
  Misses        286      286              
Files Coverage Δ
src/spatialdata_plot/pl/basic.py 87.50% <100.00%> (+0.06%) ⬆️
src/spatialdata_plot/pl/render.py 88.30% <66.66%> (-0.54%) ⬇️

... and 1 file with indirect coverage changes

@Sonja-Stockhaus Sonja-Stockhaus merged commit 0e7360c into main Dec 8, 2023
6 checks passed
@Sonja-Stockhaus Sonja-Stockhaus deleted the bugfix/issue191-cannot-stack-multiple-render-commands-of-the-same-kind branch December 8, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot stack multiple render commands of the same kind
3 participants