Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split linting and testing job #596

Merged
merged 12 commits into from Sep 17, 2022
Merged

Split linting and testing job #596

merged 12 commits into from Sep 17, 2022

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Sep 5, 2022

IMPORTANT: Please search among the Pull requests before creating one.

Description

Use separate linting job on the CI instead as a step. Fix documentation.

How has this been tested?

N/A

Closes

N/A

@michalk8 michalk8 added the ignore-towncrier Ignore automatic news generation label Sep 5, 2022
@michalk8 michalk8 self-assigned this Sep 5, 2022
@michalk8 michalk8 added the misc PR fixes something arbitrary label Sep 5, 2022
@giovp
Copy link
Member

giovp commented Sep 10, 2022

@michalk8 what I'd also like to do is using the pre-commit CI job actually, but apparently it has a ~100Mb limit and so can't use all mypy dependencies. Do you think we could drop some?

@michalk8
Copy link
Collaborator Author

@michalk8 what I'd also like to do is using the pre-commit CI job actually, but apparently it has a ~100Mb limit and so can't use all mypy dependencies. Do you think we could drop some?

Not sure what the added benefit is, tbh.

@giovp
Copy link
Member

giovp commented Sep 16, 2022

@michalk8
do you have any clue why backreferencing in docs is broken?

Details
/gen_modules/backreferences/squidpy.datasets.four_i.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.imc.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.merfish.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.mibitof.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.seqfish.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.slideseqv2.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_fluo_adata.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_fluo_adata_crop.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_fluo_image_crop.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_hne_adata.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_hne_adata_crop.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_hne_image.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.datasets.visium_hne_image_crop.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.centrality_scores.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.co_occurrence.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.interaction_matrix.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.ligrec.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.nhood_enrichment.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.ripley.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.sepal.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.spatial_autocorr.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.gr.spatial_neighbors.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.im.calculate_image_features.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.im.process.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.im.segment.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.centrality_scores.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.co_occurrence.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.extract.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.interaction_matrix.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.ligrec.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.nhood_enrichment.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.ripley.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.spatial_scatter.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.pl.spatial_segment.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.im.ImageContainer.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.im.SegmentationCustom.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.
/gen_modules/backreferences/squidpy.im.SegmentationWatershed.examples:3: WARNING: Problem with "start-after" option of "include" directive:
Text not found.

@michalk8
Copy link
Collaborator Author

@michalk8
do you have any clue why backreferencing in docs is broken?

I think this is one of the extensions (to go to src code -> docs and back), but otherwise no idea.

@giovp giovp merged commit d24dd13 into main Sep 17, 2022
@giovp giovp deleted the fix/split-linter-ci-job branch September 17, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-towncrier Ignore automatic news generation misc PR fixes something arbitrary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants