fix ligrec from pandas update #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, will check! |
|
Currently the tests fail because of matplotlib/matplotlib#24127 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 72.33% 72.54% +0.21%
==========================================
Files 37 36 -1
Lines 5177 5060 -117
Branches 982 921 -61
==========================================
- Hits 3745 3671 -74
+ Misses 1181 1146 -35
+ Partials 251 243 -8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please search among the Pull requests before creating one.
Description
@michalk8 tests fail with pandas=1.5.0 in master (but don't with pandas 1.4.0). I tried to fix it with a hack and now some tests pass but I'd like you to take a look since I'm not sure it covers behaviour.
It might (but not sure) be related to this recent bugfix pandas-dev/pandas#45715