Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix squidy.pl.ligrec's pandas usage #625

Merged
merged 3 commits into from Nov 29, 2022
Merged

Fix squidy.pl.ligrec's pandas usage #625

merged 3 commits into from Nov 29, 2022

Conversation

michalk8
Copy link
Collaborator

IMPORTANT: Please search among the Pull requests before creating one.

Description

Fix :mod:pandas in :func:squidpy.pl.ligrec.

How has this been tested?

N/A

Closes

closes #622

@michalk8 michalk8 added the bugfix PR fixes a bug label Nov 28, 2022
@michalk8 michalk8 self-assigned this Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #625 (3d19b33) into main (360a3c1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   72.52%   72.59%   +0.06%     
==========================================
  Files          36       36              
  Lines        5060     5061       +1     
  Branches      915      921       +6     
==========================================
+ Hits         3670     3674       +4     
+ Misses       1146     1145       -1     
+ Partials      244      242       -2     
Impacted Files Coverage Δ
squidpy/pl/_ligrec.py 90.72% <ø> (+0.82%) ⬆️
squidpy/pl/_spatial_utils.py 78.66% <100.00%> (+0.23%) ⬆️
squidpy/im/_io.py 67.14% <0.00%> (+0.71%) ⬆️

@michalk8 michalk8 merged commit 1397d11 into main Nov 29, 2022
@michalk8 michalk8 deleted the fix/ligrec-plotting branch November 29, 2022 09:01
@Please-help-me-Thanks
Copy link

Thank you very much for fixing this bug, I get the result that I want now, thanks again, really !

@guoguo616
Copy link

Please consider releasing this fixed version to pip, thank you

@giovp
Copy link
Member

giovp commented Feb 21, 2023

hi @guoguo616 yeah we can try to cut new release maybe end of next week? would that be fine? pinging also @LLehner for refernce

@guoguo616
Copy link

hi @guoguo616 yeah we can try to cut new release maybe end of next week? would that be fine? pinging also @LLehner for refernce

Thank you, definitely fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sq.pl.ligrec Ligand-receptor interaction analysis plotting function error
5 participants