Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix squidpy.pl.extract on views #663

Merged
merged 2 commits into from Mar 11, 2023
Merged

Fix squidpy.pl.extract on views #663

merged 2 commits into from Mar 11, 2023

Conversation

michalk8
Copy link
Collaborator

IMPORTANT: Please search among the Pull requests before creating one.

Description

Fix :func:squidpy.pl.extract on views.

How has this been tested?

1 modified test.

Closes

closes #646

@michalk8 michalk8 added the bugfix PR fixes a bug label Mar 10, 2023
@michalk8 michalk8 self-assigned this Mar 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #663 (be25179) into main (d56de03) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files          31       31           
  Lines        4468     4468           
  Branches      858      858           
=======================================
  Hits         3511     3511           
  Misses        704      704           
  Partials      253      253           
Impacted Files Coverage Δ
squidpy/pl/_graph.py 81.81% <100.00%> (ø)
squidpy/pl/_utils.py 49.12% <100.00%> (ø)

@michalk8 michalk8 merged commit fa4365d into scverse:main Mar 11, 2023
@michalk8 michalk8 deleted the fix/vizgen branch March 11, 2023 10:02
michalk8 added a commit that referenced this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sq.pl.extract doesn't work with ArrayView objects
2 participants