Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(aws): support ami as ssm links #7459

Merged
merged 2 commits into from
May 22, 2024
Merged

feature(aws): support ami as ssm links #7459

merged 2 commits into from
May 22, 2024

Conversation

fruch
Copy link
Contributor

@fruch fruch commented May 21, 2024 •
edited

with this option we can use latest of specific types of images and don't need to keep it updated manually all the time

only some of the major distro are supported, but those are exactly the ones we need

this is similar to the family type that we use in GCE

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch fruch requested a review from mikliapko May 21, 2024 06:26
@mikliapko
Copy link
Contributor

I'll trigger a couple of jobs for Manager from your branch to verify everything works

@mikliapko
Copy link
Contributor

Manager jobs:

@fruch The job for ubuntu20 has failed, the rest has passed.

@fruch
Copy link
Contributor Author

fruch commented May 21, 2024

Manager jobs:

@fruch The job for ubuntu20 has failed, the rest has passed.

seems like it failed to install syslog-ng, not clear why
the fips artifact test also failed to install one package

@fruch fruch force-pushed the aws_support_ssm_resolving branch from 40b3b3e to 352a06a Compare May 21, 2024 10:16
@fruch
Copy link
Contributor Author

fruch commented May 21, 2024

so that syslog-ng failure, and fips failure are the current blockers

fips changes I can revert if a fix isn't found for the apt keys handling

@fruch
Copy link
Contributor Author

fruch commented May 21, 2024

trying a fix for ubuntu 20 in this run:
https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/mikita/job/sct/job/manager-master/job/verify-new-images/job/ubuntu20-installation/

@fruch
Copy link
Contributor Author

fruch commented May 21, 2024

trying a fix for ubuntu 20 in this run: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/mikita/job/sct/job/manager-master/job/verify-new-images/job/ubuntu20-installation/

@mikliapko now I see you are using a different branch there, and not this branch, so my fixes are there

can you take my fixes to that branch ?

@fruch fruch force-pushed the aws_support_ssm_resolving branch from aaa0045 to 1f47583 Compare May 21, 2024 19:46
@fruch fruch added backport/2023.1 Need to backport to 2023.1 backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 labels May 21, 2024
@fruch fruch marked this pull request as ready for review May 21, 2024 19:47
@fruch
Copy link
Contributor Author

fruch commented May 21, 2024

remove the change for fips, since it's not working
see:
https://github.com/scylladb/scylla-enterprise/issues/4222
for more details

@fruch
Copy link
Contributor Author

fruch commented May 22, 2024

Running on my own job, with current job:
https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/fruch/job/manager-ubuntu20-sanity-test/1

fruch added 2 commits May 22, 2024 09:14
@fruch
feature(manager-cases): use ssm link for images
10f0f61 
this way we can get the correct latest images, per region
and can run the cases on any region we support
@fruch
feature(artifacts-tests): use ssm link for images
19571bf 
this way we can get the correct latest images, per region
and can run the cases on any region we support
@fruch fruch force-pushed the aws_support_ssm_resolving branch from 1f47583 to 19571bf Compare May 22, 2024 06:15
@mikliapko mikliapko mentioned this pull request May 22, 2024
Merged
3 tasks
@mikliapko
Copy link
Contributor

mikliapko commented May 22, 2024 •
edited

trying a fix for ubuntu 20 in this run: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/mikita/job/sct/job/manager-master/job/verify-new-images/job/ubuntu20-installation/

@mikliapko now I see you are using a different branch there, and not this branch, so my fixes are there

can you take my fixes to that branch ?

Sorry, missed your comment.
Yes, it was my own branch with your commits cherry-picked because these installation tests are not merged yet.

But as I see the request is not relevant anymore as your ubuntu20 job has passed.

@fruch
Copy link
Contributor Author

fruch commented May 22, 2024

trying a fix for ubuntu 20 in this run: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/mikita/job/sct/job/manager-master/job/verify-new-images/job/ubuntu20-installation/

@mikliapko now I see you are using a different branch there, and not this branch, so my fixes are there
can you take my fixes to that branch ?

Sorry, missed your comment. Yes, it was my own branch with your commits cherry-picked because these installation tests are not merged yet.

But as I see the request is not relevant anymore as your ubuntu20 job has passed.

@mikliapko I have on run failed the same, and one run passed

It's some instability which isn't related to those changes.

@soyacz would be working on some improvments to what we do inside cloud-init, that might address it

@fruch fruch merged commit 10e123e into scylladb:master May 22, 2024
5 checks passed
@fruch fruch added backport/manager-3.2 backport/5.4-done Commit backported to 5.4 backport/2023.1-done Commit backported to 2023.1 backport/2024.1-done Commit backported to 2024.1 backport/manager-3.2-done labels May 22, 2024
This was referenced Jun 9, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikliapko mikliapko mikliapko approved these changes

Assignees

@fruch fruch

Labels
backport/manager-3.2-done backport/manager-3.2 backport/5.4-done Commit backported to 5.4 backport/5.4 Need backport to 5.4 backport/6.0 backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1 backport/2024.1-done Commit backported to 2024.1 backport/2024.1 Need backport to 2024.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fruch @mikliapko