Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: config: add a flag to disable new reversed reads algorithm #9908

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

kbr-
Copy link
Contributor

@kbr- kbr- commented Jan 12, 2022

Just in case the new algorithm turns out to be buggy, or give a
performance regression, add a flag to fall-back to the old algorithm for
use in the field.

Just in case the new algorithm turns out to be buggy, or give a
performance regression, add a flag to fall-back to the old algorithm for
use in the field.
@kbr-
Copy link
Contributor Author

kbr- commented Jan 12, 2022

Dtest: https://github.com/scylladb/scylla-dtest/pull/2534

I developed the PR against an older master branch (05fa3e0), the dtest passed there
Unfortunately after rebasing it was no longer passing
Turns out that paged queries are broken on master: #9907
But in the meantime this PR can be reviewed

@kbr- kbr- requested review from denesb and tgrabiec January 12, 2022 18:20
denesb added a commit that referenced this pull request Jan 13, 2022
…' from Kamil Braun

Just in case the new algorithm turns out to be buggy, or give a
performance regression, add a flag to fall-back to the old algorithm for
use in the field.

Closes #9908

* github.com:scylladb/scylla:
  db: config: add a flag to disable new reversed reads algorithm
  replica: table: remove obsolete comment about reversed reads
avikivity pushed a commit that referenced this pull request Jan 13, 2022
…' from Kamil Braun

Just in case the new algorithm turns out to be buggy, or give a
performance regression, add a flag to fall-back to the old algorithm for
use in the field.

Closes #9908

* github.com:scylladb/scylla:
  db: config: add a flag to disable new reversed reads algorithm
  replica: table: remove obsolete comment about reversed reads
@scylladb-promoter scylladb-promoter merged commit d6efe27 into scylladb:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants