Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSP processor #191

Closed
sczerwinski opened this issue Dec 24, 2021 · 4 comments · Fixed by #259
Closed

KSP processor #191

sczerwinski opened this issue Dec 24, 2021 · 4 comments · Fixed by #259
Assignees
@sczerwinski
Labels
enhancement New feature or request
Milestone
1.4.0

Comments

@sczerwinski
Copy link
Owner

sczerwinski commented Dec 24, 2021 •
edited
Loading

Implement hilt-processor as KSP processor (either in the same library, or as a separate hilt-processor-ksp library).

The KSP processor should duplicate the functionality of the existing Kapt processor, but it should be managed by KSP instead.

Ticket for official KSP support for Hilt: https://issuetracker.google.com/issues/179057202
@sczerwinski sczerwinski added the enhancement New feature or request label Dec 24, 2021
@sczerwinski sczerwinski self-assigned this Dec 24, 2021
@sczerwinski sczerwinski added this to the 1.4.0 milestone Dec 24, 2021
@sczerwinski
Copy link
Owner Author

sczerwinski commented Dec 24, 2021 •
edited
Loading

This is also an opportunity to properly refactor existing Kapt processor.

EDIT: Both processors use completely different means of visiting code structure and code generation. No point in refactoring Kapt processor, which will be deprecated as soon as Hilt KSP processor is ready.

@Kshitij09-sc
Copy link

Any reason you didn't implement it already? What are the current blockers to write a hilt extension using KSP?

@sczerwinski
Copy link
Owner Author

Thanks for your question, @Kshitij09-sc

The main reason is me working on other projects. KSP simply wasn't high enough priority, as kapt is still necessary for projects using Hilt anyway.

I'll try to spend some time on this issue as soon as I get a bit less busy elsewhere.

@sczerwinski sczerwinski pinned this issue Dec 2, 2022
This was referenced Apr 9, 2023
Closed
Merged
@sczerwinski sczerwinski unpinned this issue Apr 23, 2023
@sczerwinski
Copy link
Owner Author

v1.4.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sczerwinski sczerwinski

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Implement KSP processor sczerwinski/android-hilt
2 participants
@sczerwinski @Kshitij09-sc