Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with widgetNames in UI #16

Open
morgan55555 opened this issue Apr 25, 2024 · 1 comment
Open

Issues with widgetNames in UI #16

morgan55555 opened this issue Apr 25, 2024 · 1 comment

Comments

@morgan55555
Copy link

There is too much cloned defaults in widgetDefaults.ts, but it always will be not enough for endless custom nodes for ComfyUI.
And if we change widgetNames to another (not from our node widget) - this will break correct widget loading in UI (tried with KSampler Config (rgthree), which has field "steps_total", if widgetNames is just "steps" - widget will show default value instead of real node value. If
widgetNames is "steps_total" - there is no default/step/min/max values.)

Better solution will be using only widgetIdxs, remove all widgetNames and change it to widgetTypes (e.g. steps, cfg, etc...), which can be used for any selected widgetIdxs.

Also, sometimes may be need to set custom widget parameters instead of its type (min/max/step).

@morgan55555
Copy link
Author

Also, another problem with widgetNames: if childrin using same nodeId and widgetNames, it's values will be same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant