Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports-zoneinfo does not compile on 3.10, and hard to package (pyinstaller, zipapp,...) #796

Closed
gsemet opened this issue Jan 16, 2024 · 3 comments

Comments

@gsemet
Copy link

gsemet commented Jan 16, 2024

Can you remove the dependency on backports-zoneinfo, or make it optional ? It is hard to package into a shiv executable (zipapp) that will run on python 3.9 and 3.10, because this (ugly) package does not compile on 3.10 (instead of just doing nothing silently.

Thanks

@Secrus
Copy link
Collaborator

Secrus commented Jan 17, 2024

backports-zoneinfo is only used on Python 3.8. If it's being picked up on 3.9+, it's an issue with your packaging software, not with Pendulum.

@Secrus Secrus closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@gsemet
Copy link
Author

gsemet commented Jan 17, 2024

Have tried to use pendulum in a shiv (zipapp)? It basically create a single package for several version of python (usually) so there is no way to provide the marker pip can use.

@Secrus
Copy link
Collaborator

Secrus commented Jan 18, 2024

I suggest you take it to shiv authors. PEP 508 markers are a proper way to use conditional dependencies and should be respected by installers of any kind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants