Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OAuth server-to-server authentication #178

Open
charlie-gallagher opened this issue Dec 2, 2023 · 7 comments
Open

Add support for OAuth server-to-server authentication #178

charlie-gallagher opened this issue Dec 2, 2023 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@charlie-gallagher
Copy link
Collaborator

Issue

JWT authentication is deprecated and will only be supported until January 1, 2025. Current integrations using JWT will need to migrate to OAuth Server to Server prior to January 1, 2025.

Source: https://developer.adobe.com/analytics-apis/docs/2.0/guides/#authentication

From what I can see we don't support this yet, and we should make an update to the documentation as well

Expected Resolution

Add support for it (instructions). My company doesn't yet have a OAuth server-to-server API setup, so I can't test this directly yet. @benrwoodard Let me know if you have access to one we can collaborate on this maybe in early 2024?

@charlie-gallagher charlie-gallagher added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 2, 2023
@charlie-gallagher
Copy link
Collaborator Author

This migration guide might also be useful to include in readme: https://developer.adobe.com/developer-console/docs/guides/authentication/ServerToServerAuthentication/migration/

@benrwoodard
Copy link
Contributor

This has been on my radar for sure. According to the end of life documentation, we need to support the new S2S Oauth before May 1. My limited discovery/ inquiry into it made httr2 vs httr. I would like your thoughts on whether the new features of the httr2 package would lead to faster and more efficient development of the auth functions. It seems to have additional prebuilt support for Oauth and S2S Oauth but I may be missing something.

@hein3r
Copy link

hein3r commented Apr 30, 2024

Any updates to this issue? I am somewhat dependent on this OAuth-Feature. So it would be very cool, if you guys could provide this.

@benrwoodard
Copy link
Contributor

Hey @hein3r,
I haven't added support for S2S oauth yet but the standard oauth flow is not impacted by this change. The impact is related to the JWT authentication process. That authorization is due to expire in January 2025 according to the documentation.

@hein3r
Copy link

hein3r commented May 16, 2024

Hi @benrwoodard,
thanks for the hint. However, I need to eliminate most (preferably all) manual user interaction involved in the authentification process. My hope was, that the S2S-oauth-feature would provide that, maybe by storing the refresh token somewhere indefinitively, once it was manually generated. Also, the authenfiication process is triggered by a script running in a Posit Workbench server instance.

@benrwoodard
Copy link
Contributor

This makes a lot more sense. Thank you for the clarity. So JWT is the way to get that done now. The S2S is going to provide that once we get that added. I'll leave this issue open and keep you posted on the progress.

@benrwoodard benrwoodard self-assigned this May 27, 2024
@jazzyjens25
Copy link

Hello Ben, would you be so kind to share your plans for the S2S authorization in adobeanalyticsr here? I have to move to S2S authorization soon for one of my projects that uses your very useful package and would like to manage expectations. Thank you for making my life easier with your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants