Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gvm_auto_{install,use} in $GVM_DIR/etc/config #118

Merged
merged 3 commits into from
Jan 24, 2013

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Jan 23, 2013

These flags are consulted when gvm is asked to use an uninstalled version
or to install an unused version. User is prompted for a response
by default but this can be overridden by adding these flags to
the confg, e.g.

Fixes #101

$ echo gvm_auto_install=Y >> $GVM_DIR/etc/config
$ echo gvm_auto_use=Y >> $GVM_DIR/etc/config
$ gvm use groovy 1.8.8
... (installs and uses without prompting)

Fixes sdkman#101.

These flags are consulted when gvm is asked to use an uninstalled version
or to install an unused version.  User is prompted for a response
by default but this can be overridden by adding these flags to
the confg, e.g.

$ echo gvm_auto_install=Y >> $GVM_DIR/etc/config
$ echo gvm_auto_use=Y >> $GVM_DIR/etc/config
$ gvm use groovy 1.8.8
... (installs and uses without prompting)
@dsyer
Copy link
Contributor Author

dsyer commented Jan 23, 2013

Makes sense. New patch (as a separate commit) is available.

@pledbrook
Copy link
Contributor

Maybe I just like being difficult, but the two separate options make sense to me. Would anyone configure each differently? Maybe not, but I learned not to second-guess users a long time ago. Plus I find the gvm_auto name confusing 😄

@marc0der
Copy link
Member

@pledbrook I like to configure things only when the requirement is there. Clearly there is a requirement for the config, but not for both individually. I again have worked on projects where everything was configured to death, resulting in an extremely difficult to maintain (and deploy!) code base. Since then I've learnt to do only what is required.

Thinking we should keep it as one config, but agree that the name is a bit misleading (sorry @dsyer :-X)

@dsyer
Copy link
Contributor Author

dsyer commented Jan 24, 2013

OK what would you suggest (gvm_auto_use_or_install_depending_on_the_context)?

@marc0der
Copy link
Member

continuous_integration_environment or auto_answer perhaps?

marc0der added a commit that referenced this pull request Jan 24, 2013
Add gvm_auto_{install,use} in $GVM_DIR/etc/config
@marc0der marc0der merged commit 3d9ad36 into sdkman:master Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce quiet mode for install
3 participants