Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: proposal for a way to configure dimmer colors #600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fditolla
Copy link

@fditolla fditolla commented Aug 25, 2017

proposal for a way to configure colors that are more readable on light terminals, using a config variable named 'sdkman_colour_style' defaulting to 1 and that when set to 2 uses dimmer colors suitable to white/light colored terminals. (I could not add the variable to the script executed upon installation since it is not under configuration here).

… light terminals, using a config variable named 'sdkman_colour_style' defaulting to 1 and that when set to 2 dimmer colors suitable to white/light colored terminals
@marc0der
Copy link
Member

I like the idea, but think it might be more beneficial if the colour be turned off completely. I like the use of the variable, but would probably call it something like sdkman_colour_enable.

@marc0der marc0der force-pushed the master branch 4 times, most recently from 23b054e to 7ee2c51 Compare August 26, 2017 12:13
@fditolla
Copy link
Author

sdkman_colour_enable=true is already included in the config file, and it works correctly, this was to change the color to dim them, alternatively you could put a fixed "2" in place of the variable I introduced in the colored echo

@marc0der
Copy link
Member

Evidently, it's been a while since I implemented that :-)

Would it be possible to somehow make the config read something like:

sdkman_colour_style=dark/light

That would be more intuitive for people trying to configure this.

@fditolla
Copy link
Author

I've committed the change you suggested.
I've seen the new indication on contributions: apologies for not having posted in gitter before branching and proposing the change.

… set to light/dark instead of the numeric values 1/2 (to be precise dark is detected for dimmed colors and anything else defaults to light)
Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, although as it stands it will default to the light configuration (since sdkman_colour_style has never been set explicitly.

We require some further work to be done in the sdkman-hooks service to add this new configuration to the config file.

Don't worry about the Gitter bit, this is a new process that was introduced only after you raised your PR ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants