Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "auto" values for rows/columns #18

Closed
oliverjam opened this issue May 28, 2019 · 4 comments
Closed

Allow "auto" values for rows/columns #18

oliverjam opened this issue May 28, 2019 · 4 comments

Comments

@oliverjam
Copy link

It would be nice to support auto, as well as max-content and min-content for row and column sizes.

I imagine adding tests for them here would work:

/fr/.test(unit) ||
/px/.test(unit) ||
/%/.test(unit) ||
/em/.test(unit) ||
/rem/.test(unit) ||
/vw/.test(unit) ||
/vh/.test(unit) ||
/vmin/.test(unit);

But I'm not sure how to visualise that on the grid (since the rows/columns have no content to size by). Maybe just default to a ~2rem height/width? We can probably assume the user knows what they're doing if they've typed min-content in.

I've never written any Vue before but happy to learn to try and PR if you think this would be worthwhile.

@sdras
Copy link
Owner

sdras commented Jun 2, 2019

Sure, I'd take a PR for this :) I was going to offer to just do it, but if you'd like to take a stab at it to learn, that's great!

@sdras
Copy link
Owner

sdras commented Aug 24, 2019

Hey there, still working on this? If not, I can add it myself. Thanks!

@oliverjam
Copy link
Author

Hey, sorry but to be honest I completely forgot about this! I haven't even started so if you want to add it yourself please go ahead :)

@sdras
Copy link
Owner

sdras commented Oct 3, 2019

Fixed!

@sdras sdras closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants