Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectReferenceAttributes bug #38

Closed
lencioni opened this issue Oct 9, 2014 · 4 comments
Closed

ObjectReferenceAttributes bug #38

lencioni opened this issue Oct 9, 2014 · 4 comments
Labels

Comments

@lencioni
Copy link
Contributor

lencioni commented Oct 9, 2014

haml-lint 0.7.0 is reporting a problem from ObjectReferenceAttributes on the first line of the following haml:

%h3 Test
%p hi
@lencioni lencioni added the bug label Oct 9, 2014
@lencioni
Copy link
Contributor Author

Interesting, I added this test case to spec/haml_lint/linter/object_reference_attributes_spec.rb, and it passes just fine.

context 'when a tag has no attributes followed by a tag with no attributes' do
  let(:haml) { <<-HAML }
    %h3 Test
    %p hi
  HAML

  it { should_not report_lint }
end

@sds
Copy link
Owner

sds commented Nov 11, 2014

Hey @lencioni,

I'm unable to reproduce this locally by running haml-lint directly with a file containing the contents you posted. I'm going to close, but feel free to reopen if there's something I'm missing.

@sds sds closed this as completed Nov 11, 2014
@sds
Copy link
Owner

sds commented Nov 11, 2014

This seems to have something to do with your system running the latest version of the haml gem (4.1.0.beta.1 at time of writing).

This version likely mucked around with the parse tree representation. Will have a look when I can.

@sds
Copy link
Owner

sds commented Nov 21, 2014

Fixed in 18bd4ba and released in 0.8.0

@sds sds closed this as completed Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants