Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to avoid IDs #292

Closed
felquis opened this issue Nov 15, 2014 · 3 comments
Closed

Add option to avoid IDs #292

felquis opened this issue Nov 15, 2014 · 3 comments

Comments

@felquis
Copy link

felquis commented Nov 15, 2014

In the session IdWithExtraneousSelector the last line is about:

Even better would be to never use IDs in the first place.

We don't have an option to avoid IDs, would be great to have one :)

@anselmh
Copy link

anselmh commented Nov 21, 2014

If you don’t want to support this by default (I’d love to set this also as option), #161 could help here.

@sds sds added the enhancement label Dec 1, 2014
@sds
Copy link
Owner

sds commented Dec 1, 2014

Thinking about this, it seems like IdWithExtraneousSelector wasn't being opinionated enough—using IDs in selectors is a smell and should be avoided entirely.

I've renamed IdWithExtraneousSelector to IdSelector and modified its behavior to report a lint if an ID ever appears in a selector (and thus made it stricter) in aea47bb.

@sds sds closed this as completed Dec 1, 2014
@felquis
Copy link
Author

felquis commented Dec 2, 2014

I'm sorry @anselmh I don't have any experience with Ruby to help :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants