Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Camera Hardcode #73

Closed
sin3point14 opened this issue Mar 9, 2020 · 0 comments · Fixed by #139
Closed

Fix Camera Hardcode #73

sin3point14 opened this issue Mar 9, 2020 · 0 comments · Fixed by #139
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Core gameplay fea...

Comments

@sin3point14
Copy link
Contributor

Camera Position has been hardcoded here
https://github.com/sdslabs/Rootex/blob/master/rootex/framework/components/visual/camera_visual_component.cpp#L14

This shouldn't be so and relevant hardcoded values should be removed from vertex shaders as well.
Possible add naive camera controls.
@sin3point14 sin3point14 added bug Something isn't working good first issue Good for newcomers labels Mar 9, 2020
@twaritwaikar twaritwaikar added this to the Core gameplay features milestone Mar 15, 2020
@sin3point14 sin3point14 mentioned this issue Mar 20, 2020
Closed
@twaritwaikar twaritwaikar mentioned this issue Mar 21, 2020
Closed
@angad-k angad-k mentioned this issue Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Core gameplay features
Development

Successfully merging a pull request may close this issue.

camera hardcode fix sdslabs/Rootex
2 participants
@twaritwaikar @sin3point14