Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle actor stop #17

Closed
albireox opened this issue Apr 16, 2021 · 0 comments · Fixed by #18
Closed

Handle actor stop #17

albireox opened this issue Apr 16, 2021 · 0 comments · Fixed by #18
Assignees

Comments

@albireox
Copy link
Member

Right now when we shut down the actor from the command line (whether it's with --debug or with the daemon) the connection to the Archons is not closed. This seems to cause that if you reconnect soon after and try to write the config, sometimes that raises and error.

I should handle this better by catching the SIGKILL/SIGTERM signal and closing the connection to the controllers before exiting. This should be added to ArchonActor.stop() as part of the shutdown. For the daemon I'm not sure if handling the signals will be enough, but it's the first thing to try.

@albireox albireox self-assigned this Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant