Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that prevented exposure times longer than 1000 seconds.
Parameters in the Archon language cannot have values larger than one million. Since the exposure time was set in milliseconds, a 1000 seconds exposure was 1,000,000 milliseconds and thus the limit. This PR introduces a breaking change in which we set the exposure time in centiseconds (yes, centiseconds) allowing exposure times of up to 10,000 seconds. This requires changing the ACF files that work with Archon to use a new
IntCS
parameter which stores the integration time in centiseconds. Then we need to change fromto
and add a new function
All in all this is not a super satisfying solution but it's unlikely we need exposure times longer than 10,000 seconds and any other solution would either be limiting (for example setting the exposure time in seconds, which would limit us to an integer number of seconds) or more complicated (e.g., adding an additional parameter in which we count the number of times the
IntMS
variables goes over one million).