Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use fitsio to save files #45

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Allow to use fitsio to save files #45

merged 9 commits into from
Nov 30, 2023

Conversation

albireox
Copy link
Member

Introduces a new option files.write_engine that can be set to astropy or fitsio. In the latter case it will use fitsio to write images to disk. This requires installing sdss-archon with the fitsio extra (e.g., pip install sdss-archon[fitsio].

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de8e771) 84.7% compared to head (9ede3e3) 85.1%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #45     +/-   ##
=======================================
+ Coverage   84.7%   85.1%   +0.5%     
=======================================
  Files         21      21             
  Lines       1956    1990     +34     
  Branches     496     503      +7     
=======================================
+ Hits        1656    1693     +37     
+ Misses       205     203      -2     
+ Partials      95      94      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit 7235fab into main Nov 30, 2023
6 checks passed
@albireox albireox deleted the albireox-fitsio branch November 30, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant