Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Change how matplotlib gets imported #43

Closed
albireox opened this issue Nov 2, 2016 · 3 comments
Closed

[CLOSED] Change how matplotlib gets imported #43

albireox opened this issue Nov 2, 2016 · 3 comments
Labels
enhancement indicates a new feature or functionality to be added
Milestone
Marvin Beta

Comments

@albireox
Copy link
Member

albireox commented Nov 2, 2016

Issue by albireox
Wednesday Jul 06, 2016 at 18:07 GMT
Originally opened as https://github.com/marvin-manga/marvin/issues/2

For code reutilisation, let's change all my import matplotlib.pyplot to import matplotlib.pyplot as plt.
@albireox
Copy link
Member Author

albireox commented Nov 2, 2016

Comment by albireox
Wednesday Jul 06, 2016 at 23:27 GMT

Fixed.

@albireox albireox added this to the Marvin Beta milestone Nov 2, 2016
@albireox albireox added the enhancement indicates a new feature or functionality to be added label Nov 2, 2016
@albireox
Copy link
Member Author

albireox commented Nov 2, 2016

Comment by bretthandrews
Thursday Jul 07, 2016 at 02:54 GMT

Let the circular imports begin!

Seriously though thank you very much! I think that it was bothering me on a similar level as having uninstalled updates in Atom---which you can rest assured I am still current on.

@albireox
Copy link
Member Author

albireox commented Nov 2, 2016

Comment by albireox
Thursday Jul 07, 2016 at 05:45 GMT

Wow, that a really high level of bothering. I completely sympathy. If we get circular imports from matplotlib is that we are doing something seriously wrong.

@albireox albireox closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement indicates a new feature or functionality to be added
Projects
None yet
Milestone
Marvin Beta
Development

No branches or pull requests
1 participant
@albireox