Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instances of axios to use the new global instance #25

Open
havok2063 opened this issue Jun 26, 2024 · 1 comment · May be fixed by #27
Open

Update instances of axios to use the new global instance #25

havok2063 opened this issue Jun 26, 2024 · 1 comment · May be fixed by #27
Assignees
@albireox
Labels
enhancement New feature or request

Comments

@havok2063
Copy link
Contributor

We should update either some or all of the instances of axios in the code to use the new global instance added in #24. That way any request can take advantage of the JSONbig response. We should look into adding the custom headers for authentication into this config.
@havok2063 havok2063 added the enhancement New feature or request label Jun 26, 2024
@albireox albireox mentioned this issue Jun 26, 2024
Merged
@albireox albireox self-assigned this Jun 26, 2024
@havok2063
Copy link
Contributor Author

We should add withCredentials: true to the global config for auth stuff. See https://axios-http.com/docs/req_config

@albireox albireox linked a pull request Jun 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albireox albireox

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use axiosInstance for all components sdss/zora
2 participants
@albireox @havok2063