Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide user-defined callback function to CTGANSyntesizer #256

Closed
PJPRoche opened this issue Nov 24, 2022 · 1 comment
Closed
Labels
feature request Request for a new feature resolution:duplicate This issue or pull request already exists

Comments

@PJPRoche
Copy link

Problem Description

Only in verbose model can you see Generator and Discriminator loss metrics at the end of each epoch. This is useful for a basic visual confirmation that the model is running but does not allow for detailed quantitative inspection of the model as it is training.

Expected behavior

It would be helpful if the user could supply a function, for example passed to the CTGANSynthesizer class when instantiated, that would then be called at the end of each epoch. Ideally, from your callback, you would want to call something like the sample function at the end of each epoch to obtain synthetic data and then subject this synthetic data to some of the SD Metrics. But with sample being a member function of the CTGANSynthesizer class this is arguably a bit awkward.

@PJPRoche PJPRoche added feature request Request for a new feature pending review This issue needs to be further reviewed, so work cannot be started labels Nov 24, 2022
@npatki
Copy link
Contributor

npatki commented Nov 29, 2022

Hi @PJPRoche, thanks for filing. The idea makes sense to me, and I agree we'd have to think more about the workflow and API part.

I believe we have an existing issue about callbacks here: sdv-dev/SDV#460

This would involve a larger refactor of the existing CTGAN model, so we haven't been able to add it to our roadmap yet. But every new issue, use case and request that we hear about helps us prioritize! I'll mark this as a duplicate of the issue linked above -- feel free to add your use case and requirements to it.

@npatki npatki closed this as completed Nov 29, 2022
@npatki npatki added resolution:duplicate This issue or pull request already exists and removed pending review This issue needs to be further reviewed, so work cannot be started labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature resolution:duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants