Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out sdtype validations from multi-column transformers #778

Closed
R-Palazzo opened this issue Apr 3, 2024 · 0 comments · Fixed by #779
Closed

Move out sdtype validations from multi-column transformers #778

R-Palazzo opened this issue Apr 3, 2024 · 0 comments · Fixed by #779
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@R-Palazzo
Copy link
Contributor

Problem Description

Currently, all the sdtype validations for multi-column transformers are defined in their classes.
We want to move these validations out of the classes into a separate file so that they can be used without accessing the transformers.

Expected behavior

  • Create a _validations.py file inside rdt/transformers
  • Move out all the sdtype validations for the multi-column transformer inside this file
  • Make the changes so the multi-column transformer usage stays the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants