Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pydocstyle #100

Merged
merged 3 commits into from Nov 9, 2021
Merged

Add pydocstyle #100

merged 3 commits into from Nov 9, 2021

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 5, 2021

As part of #80, add pydocstlyle and update the code accordingly.

@fealho fealho marked this pull request as ready for review November 5, 2021 18:05
@fealho fealho requested a review from a team as a code owner November 5, 2021 18:05
@fealho fealho requested review from pvk-developer and katxiao and removed request for a team November 5, 2021 18:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #100 (2d47c9a) into issue-80-base (270a73e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           issue-80-base     #100   +/-   ##
==============================================
  Coverage          51.16%   51.16%           
==============================================
  Files                 50       50           
  Lines               1503     1503           
==============================================
  Hits                 769      769           
  Misses               734      734           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270a73e...2d47c9a. Read the comment docs.

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it 👍🏻

@fealho fealho merged commit 3f369c1 into issue-80-base Nov 9, 2021
@fealho fealho deleted the issue-80-pydocstyle branch November 9, 2021 07:21
fealho added a commit that referenced this pull request Nov 9, 2021
* Fix existing lint errors

* Make double quotes into single (#92)

* Add `flake8` addons that pass in the existing code (#91)

* Add addons which do not require any code changes

* Remove pydostyle

* Remove flake8-use-fstring

* Fix lint errors of new addon (#93)

* Add `pep8-naming` (#94)

* Fix lint according to new addon

* Rename Y_col

* Add `pandas-vet` (#95)

* Fix some lint errors

* Fix lint according to added addon

* Change .array to .to_numpy()

* Add `dlint` (#96)

* Add addon

* Ignore all DUO103

* Add `flake8-docstrings` (#98)

* Fix D401

* Fix D401

* Fix lint

* Remove __init__ docstrings

* Add addon (#99)

* Add `pydocstyle` (#100)

* Add pydocstyle

* Remove ignore from flake8

* Update setup.cfg

* Update setup.py

* Add `flake8-variables` (#97)

* Add addon

* Update setup.cfg

* Add ignore docstrings on for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants