Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addons to improve lint checking #90

Merged
merged 14 commits into from Nov 9, 2021
Merged

Add addons to improve lint checking #90

merged 14 commits into from Nov 9, 2021

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 4, 2021

Resolve #80.

This is the base PR in which all other addons will be added (each one will be implemented in a different PR).

@fealho fealho changed the title Add addons to increase code style lint Add addons to improve lint checks Nov 4, 2021
@fealho fealho changed the title Add addons to improve lint checks Add addons to improve lint check Nov 4, 2021
@fealho fealho changed the title Add addons to improve lint check Add addons to improve lint checking Nov 4, 2021
@fealho fealho marked this pull request as ready for review November 5, 2021 16:42
@fealho fealho requested a review from a team as a code owner November 5, 2021 16:42
@fealho fealho requested review from amontanez24 and katxiao and removed request for a team November 5, 2021 16:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #90 (45fe99d) into master (d2bbd4e) will not change coverage.
The diff coverage is 40.54%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   51.16%   51.16%           
=======================================
  Files          50       50           
  Lines        1503     1503           
=======================================
  Hits          769      769           
  Misses        734      734           
Impacted Files Coverage Δ
sdmetrics/base.py 77.50% <0.00%> (ø)
...dmetrics/column_pairs/statistical/kl_divergence.py 61.53% <0.00%> (ø)
sdmetrics/multi_table/detection/base.py 83.33% <ø> (ø)
sdmetrics/single_column/statistical/cstest.py 68.42% <ø> (ø)
sdmetrics/single_column/statistical/kstest.py 72.22% <ø> (ø)
sdmetrics/single_table/bayesian_network.py 46.15% <0.00%> (ø)
sdmetrics/single_table/detection/base.py 47.50% <0.00%> (ø)
sdmetrics/single_table/efficacy/__init__.py 100.00% <ø> (ø)
sdmetrics/single_table/efficacy/binary.py 75.00% <ø> (ø)
sdmetrics/single_table/efficacy/mlefficacy.py 0.00% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2bbd4e...45fe99d. Read the comment docs.

Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this in advance, before all the other stacked PRs are merged into this one, since the rest of changes will have been approved on their own already

* Add addons which do not require any code changes

* Remove pydostyle

* Remove flake8-use-fstring
* Fix lint according to new addon

* Rename Y_col
* Fix some lint errors

* Fix lint according to added addon

* Change .array to .to_numpy()
* Add addon

* Ignore all DUO103
* Fix D401

* Fix D401

* Fix lint

* Remove __init__ docstrings
* Add pydocstyle

* Remove ignore from flake8
* Add addon

* Update setup.cfg
@fealho fealho merged commit cfacd8c into master Nov 9, 2021
@fealho fealho deleted the issue-80-base branch November 9, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code style lint
5 participants