New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pep8-naming
#94
Add pep8-naming
#94
Conversation
setup.cfg
Outdated
@@ -34,6 +34,7 @@ universal = 1 | |||
[flake8] | |||
max-line-length = 99 | |||
exclude = docs, .tox, .git, __pycache__, .ipynb_checkpoints | |||
ignore-names = X, Y, X_train, X_test, Y_col |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this names are very standard and acceptable, but I think this is not true for Y_col
.
If it is not a huge change, I'd prefer to remove this from the list and adapt the corresponding code.
Codecov Report
@@ Coverage Diff @@
## issue-80-base #94 +/- ##
==============================================
Coverage 51.16% 51.16%
==============================================
Files 50 50
Lines 1503 1503
==============================================
Hits 769 769
Misses 734 734
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Fix existing lint errors * Make double quotes into single (#92) * Add `flake8` addons that pass in the existing code (#91) * Add addons which do not require any code changes * Remove pydostyle * Remove flake8-use-fstring * Fix lint errors of new addon (#93) * Add `pep8-naming` (#94) * Fix lint according to new addon * Rename Y_col * Add `pandas-vet` (#95) * Fix some lint errors * Fix lint according to added addon * Change .array to .to_numpy() * Add `dlint` (#96) * Add addon * Ignore all DUO103 * Add `flake8-docstrings` (#98) * Fix D401 * Fix D401 * Fix lint * Remove __init__ docstrings * Add addon (#99) * Add `pydocstyle` (#100) * Add pydocstyle * Remove ignore from flake8 * Update setup.cfg * Update setup.py * Add `flake8-variables` (#97) * Add addon * Update setup.cfg * Add ignore docstrings on for tests
As part of #80 added
pep8-naming
addon forflake8
and adapted our code to follow this style.