Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create single table synthesis property #390

Closed
amontanez24 opened this issue Jul 19, 2023 · 1 comment · Fixed by #398
Closed

Create single table synthesis property #390

amontanez24 opened this issue Jul 19, 2023 · 1 comment · Fixed by #398
Assignees
Labels
feature request Request for a new feature internal The issue doesn't change the API or functionality
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

Now that we have property classes, we want to move the metrics used in the DiagnosticReport into their respective properties.

This is the spec for the Synthesis property

Attributes

  • _details - A dataframe containing the following columns
    • 'Metric'
    • 'Score'
    • 'Num Matched Rows'
    • 'Num New Rows'

The metrics used in this class are: [NewRowSynthesis]

Methods

  • _generate_details(self, real_data, synthetic_data, metadata, progress_bar) - Generate the _details dataframe that will be used by the base class to get the score.
    Pseudocode:
score = NewRowSynthesis.compute_breakdown(real_data, synthetic_data, synthetic_sample_size: 10000)
  • get_visualization() - Returns a plotly.graph_objects._figure.Figure object for the specified table. Use code similar to what's in get_synthesis_plot.

Expected behavior

>>> prop = Synthesis()
>>> prop.get_score()
>>> 0.89
>>> prop.get_visualization()

Additional context

  • we should catch any exceptions the same way we do here
@amontanez24 amontanez24 added internal The issue doesn't change the API or functionality feature request Request for a new feature labels Jul 19, 2023
@amontanez24 amontanez24 changed the title Create single table synthesis propery Create single table synthesis property Jul 19, 2023
@amontanez24 amontanez24 added this to the 0.11.1 milestone Jul 26, 2023
@amontanez24
Copy link
Contributor Author

Closed by #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants