Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMA1 with non parametric tabular models: improve the error message #362

Closed
csala opened this issue Mar 24, 2021 · 1 comment
Closed

HMA1 with non parametric tabular models: improve the error message #362

csala opened this issue Mar 24, 2021 · 1 comment
Labels
bug Something isn't working resolution:obsolete This is no longer an issue

Comments

@csala
Copy link
Contributor

csala commented Mar 24, 2021

Error Description

When HMA1 is used with a non-parametrical model the message that informs the user about the model not being parametric is being wrongly caught on this try/except block and it ends up producing a cryptic error message. See #340.

Steps to reproduce

See #340.

How to Fix

We should modify the except block to let the NonParametricError go up.

Another possibility to consider is to add a control during instantiation to certify that the model is actually parametric before even starting to fit on the data.

@csala csala added the bug Something isn't working label Mar 24, 2021
@sync-by-unito sync-by-unito bot changed the title HMA1 with non parametric tabular models: improve the error message SDV - #362 HMA1 with non parametric tabular models: improve the error message Apr 13, 2021
@sync-by-unito sync-by-unito bot changed the title SDV - #362 HMA1 with non parametric tabular models: improve the error message HMA1 with non parametric tabular models: improve the error message Apr 13, 2021
@csala csala added the approved label Aug 26, 2021
@npatki npatki removed the approved label Jul 1, 2022
@npatki
Copy link
Contributor

npatki commented Mar 9, 2023

This issues is no longer relevant after SDV 1.0 (Beta!), as we no longer expose any options that would allow users to apply a non-parametric model to this synthesizer.

For more details, see the HMASynthesizer docs.

@npatki npatki closed this as completed Mar 9, 2023
@npatki npatki added resolution:obsolete This is no longer an issue SDV 1.0 (Beta!) labels Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolution:obsolete This is no longer an issue
Projects
None yet
Development

No branches or pull requests

2 participants