Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GreaterThan constraint #368

Closed
pvk-developer opened this issue Mar 26, 2021 · 1 comment · Fixed by #485
Closed

Improve GreaterThan constraint #368

pvk-developer opened this issue Mar 26, 2021 · 1 comment · Fixed by #485
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@pvk-developer
Copy link
Member

pvk-developer commented Mar 26, 2021

Problem Description

Allow the user to pass a certain value to the GreaterThan constraint instead of just columns. Also allow the possibility to choose when using transform strategy, which value to keep (the lower or the higher).

Expected behavior

from sdv.constraints import GreaterThan

gt_int_column = GreaterThan(low=1, high='column', handling_strategy='transform', transform_value='high')
gt_column_int = GreaterThan(low='column_a', high=100, handling_strategy='transform', transform_value='low')
gt_columns = GreaterThan(low='column_a', high='column_b', handling_strategy='transform', transform_value='low')
@pvk-developer pvk-developer added feature request Request for a new feature pending review labels Mar 26, 2021
@sync-by-unito sync-by-unito bot changed the title Improve GreaterThan constraint SDV - #368 Improve GreaterThan constraint Apr 13, 2021
@sync-by-unito sync-by-unito bot changed the title SDV - #368 Improve GreaterThan constraint Improve GreaterThan constraint Apr 13, 2021
@npatki
Copy link
Contributor

npatki commented Apr 21, 2021

Is it better to add static values to this constraint, or to create other constraint(s) for this? See discussion in #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants