Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make true/false values lowercase in Metadata Schema specification #664

Closed
npatki opened this issue Dec 9, 2021 · 0 comments · Fixed by #671
Closed

Make true/false values lowercase in Metadata Schema specification #664

npatki opened this issue Dec 9, 2021 · 0 comments · Fixed by #671
Assignees
Labels
documentation Docs, user guides or API
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Dec 9, 2021

Boolean values in JSON are lowercase (true/false) even though they are uppercase in Python (True/False).

The User Guide for the Metadata Schema says it's describing JSON files at the top. However, it's including an uppercase boolean value as an example.

"social_security_number": {
    "type": "categorical",
    "pii": True,
    "pii_category": "ssn"
}

This might confuse users if they're following the guide to write their metadata.json.

@npatki npatki added the documentation Docs, user guides or API label Dec 9, 2021
@katxiao katxiao self-assigned this Dec 17, 2021
@katxiao katxiao added this to the 0.13.1 milestone Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, user guides or API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants