Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change extension check #69

Closed
ManuelAlvarezC opened this issue Oct 23, 2018 · 0 comments
Closed

Change extension check #69

ManuelAlvarezC opened this issue Oct 23, 2018 · 0 comments
Assignees
@ManuelAlvarezC
Labels
internal The issue doesn't change the API or functionality
Milestone
0.1.1

Comments

@ManuelAlvarezC
Copy link
Contributor

https://github.com/HDI-Project/SDV/blob/a0da522a9e597b00be0a3a948cb962820528a82b/sdv/modeler.py#L181.

This line contains a check to ensure an extension is not None. However this is will allow an empty extension to be processed, which in turn may cause problems later.
@ManuelAlvarezC ManuelAlvarezC added the internal The issue doesn't change the API or functionality label Oct 23, 2018
@ManuelAlvarezC ManuelAlvarezC added this to the 0.1.1 milestone Oct 23, 2018
@ManuelAlvarezC ManuelAlvarezC self-assigned this Oct 23, 2018
@ManuelAlvarezC ManuelAlvarezC mentioned this issue Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManuelAlvarezC ManuelAlvarezC

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
1 participant
@ManuelAlvarezC