Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field distributions bug in GaussianCopula #746

Closed
katxiao opened this issue Mar 29, 2022 · 0 comments · Fixed by #743
Closed

Field distributions bug in GaussianCopula #746

katxiao opened this issue Mar 29, 2022 · 0 comments · Fixed by #743
Assignees
Labels
bug Something isn't working
Milestone

Comments

@katxiao
Copy link
Contributor

katxiao commented Mar 29, 2022

In GaussianCopula _fit, we received transformed columns which have columns a.value and a.is_null if the original dataset has a column 'a'. When this happens, the field distribution does not get properly passed through to GaussianCopula since it has been specified under the key 'a'. We can fix this by matching transformed columns to the original column names.

@katxiao katxiao added bug Something isn't working pending review labels Mar 29, 2022
@katxiao katxiao self-assigned this Mar 29, 2022
@katxiao katxiao closed this as completed Mar 29, 2022
@npatki npatki changed the title Field distributions bug Field distributions bug in GaussianCopula Mar 29, 2022
@katxiao katxiao added this to the 0.14.1 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant