Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in ScalarInequality #868

Closed
amontanez24 opened this issue Jul 6, 2022 · 0 comments · Fixed by #882
Closed

Fix error message in ScalarInequality #868

amontanez24 opened this issue Jul 6, 2022 · 0 comments · Fixed by #882
Labels
bug Something isn't working
Milestone

Comments

@amontanez24
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version: 0.16.0.dev0
  • Python version: Any
  • Operating System: Any

Error Description

If I pass in an invalid value as the "value" parameter, the error says:
ValueError: `value` must be a number or datetime.

This is not technically correct. The value should be a string that represents a datetime.
New Error should say:
Value Error: `value` must be a number or a string that represents a datetime.

Steps to reproduce

constraint = ScalarInequality(column_name='age', relation='>=', value=False)
@amontanez24 amontanez24 added bug Something isn't working new Automatic label applied to new issues and removed new Automatic label applied to new issues labels Jul 6, 2022
@pvk-developer pvk-developer added this to the 0.16.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants