Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.fit method parameter #389

Closed
helderc opened this issue Apr 2, 2024 · 3 comments
Closed

.fit method parameter #389

helderc opened this issue Apr 2, 2024 · 3 comments
Labels
resolution:out of scope Copulas is not designed to solve this problem

Comments

@helderc
Copy link

helderc commented Apr 2, 2024

Hi all. First, thanks for the great library!

Considering the GaussianMultivariate as an example, does the input of .fit method expect the last column to be the samples' classes?

I'm asking because it is not mentioned in the documentation [1] that only shows the parameter X. But looking at the example [2], we see the concatenation of X and y. If the example is correct, maybe we should update the doc for clarification?

[1] https://sdv.dev/Copulas/api/copulas.multivariate.gaussian.html#copulas.multivariate.gaussian.GaussianMultivariate

[2] https://sdv.dev/Copulas/tutorials/04_Syntehtic_Data_for_Machine_Learning.html

@helderc helderc added new Automatic label applied to new issues question General question about the software labels Apr 2, 2024
@srinify
Copy link

srinify commented May 9, 2024

Hi there @helderc 👋 I'd encourage you to give SDV a try, specifically the GaussianCopulaSynthesizer. This synthesizer class is a drop-in replacement for GaussianMultivariate. SDV is a framework that sits one layer above our Copulas library and offers a significantly better user experience.

I'm also curious to know what your use case is for using gaussian copulas?

@srinify srinify removed the new Automatic label applied to new issues label May 9, 2024
@srinify srinify added the under discussion Issue is currently being discussed label May 19, 2024
@srinify
Copy link

srinify commented May 20, 2024

Closing this issue for now since GaussianCopulaSynthesizer is our recommended path forward! If you have more questions, you're welcome to join our Slack and we can also discuss more there: https://bit.ly/sdv-slack-invite

@srinify srinify closed this as completed May 20, 2024
@srinify srinify added resolution:out of scope Copulas is not designed to solve this problem and removed question General question about the software under discussion Issue is currently being discussed labels May 20, 2024
@helderc
Copy link
Author

helderc commented May 31, 2024

Thanks for the feedback @srinify , I'll definitely check SDV out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:out of scope Copulas is not designed to solve this problem
Projects
None yet
Development

No branches or pull requests

2 participants