Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch drop_missing_values in in drop_unknown_references to support null foreign keys by default #2076

Closed
R-Palazzo opened this issue Jun 18, 2024 · 0 comments
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@R-Palazzo
Copy link
Contributor

Problem Description

By default, drop_missing_values is True in drop_unknown_references, which drops the null-foreign key. With the goal of supporting null-foreign keys in all our multi-table logic, one should switch the default value of drop_missing_values to False.

Expected behavior

  • Switch the default parameter value of drop_missing_values in drop_unknown_references to False
  • Update the wrapper function in sdv/utils/poc.py accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants