Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional "OR" operator formatting is broken on the CS2113 website under the cppToJava section #114

Closed
Bawfen opened this issue May 1, 2023 · 1 comment

Comments

@Bawfen
Copy link

Bawfen commented May 1, 2023

I noticed that the format of the conditional operator is broken on the CS2113 website (https://nus-cs2113-ay2223s2.github.io/website/se-book-adapted/chapters/cppToJava.html#operators).

Screenshot 2023-05-01 at 12 56 10 PM

`||` | or | `true || false` %%{{ icon_output_right }}%% `true` | `false || false` %%{{ icon_output_right }}%% `false`

I suspect that the | character is being read as a table. We could follow the suggestion from https://stackoverflow.com/questions/17319940/how-to-escape-a-pipe-char-in-a-code-statement-in-a-markdown-table to rectify it.

Suggested Fix

<code>&vert;&vert;</code> | or | <code>true &vert;&vert; false</code> %%{{ icon_output_right }}%% `true` | <code>false &vert;&vert; false</code>  %%{{ icon_output_right }}%% `false`
@Bawfen Bawfen changed the title Conditional "OR" operator formatting is broken on the website Conditional "OR" operator formatting is broken on the CS2113 website under the cppToJava section May 1, 2023
@damithc
Copy link
Contributor

damithc commented May 1, 2023

Thanks for the fix @Bawfen
I've fixed it in this repo.

@damithc damithc closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants