Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI for different numDomains settings #413

Closed
lsf37 opened this issue Dec 21, 2021 · 6 comments
Closed

add CI for different numDomains settings #413

lsf37 opened this issue Dec 21, 2021 · 6 comments
Assignees
Labels
CI continuous integration and testing

Comments

@lsf37
Copy link
Member

lsf37 commented Dec 21, 2021

When PR #410 is merged, the proofs will be generic in the number of protection domains.

Testing that fact with every CI job is going to be too resource-intensive, but we should test at least values of 1, 2, and something like 16 in the weekly job so we get an alert when we accidentally break this genericity.

@lsf37 lsf37 added the CI continuous integration and testing label Dec 21, 2021
@lsf37 lsf37 self-assigned this Dec 21, 2021
@Xaphiosis
Copy link
Member

We already test 16 as it is the default. Did you mean another number?

@lsf37
Copy link
Member Author

lsf37 commented Dec 21, 2021

I mostly meant the weekly should also keep testing the normal default. Not sure if we want to leave it at 16, but 16 is as good as any I guess.

@lsf37 lsf37 changed the title add CI for different numDomain settings add CI for different numDomains settings Dec 21, 2021
@Xaphiosis
Copy link
Member

Then you propose adding 1 and 2 to the weekly test? That makes sense.
Other thoughts:

  • we need a branch with a commit that changes all the verified seL4 configs that keeps getting rebased before we test (we already discussed that)
  • when someone adds a new config, the above commit will not change the new config, and I have not a clue how one would track or notice that; an alternative to the above method is to take master and search+replace the number of domains in all configs

@lsf37
Copy link
Member Author

lsf37 commented Dec 21, 2021

Then you propose adding 1 and 2 to the weekly test? That makes sense.

yes, that would have been much clearer :-)

  • we need a branch with a commit that changes all the verified seL4 configs that keeps getting rebased before we test (we already discussed that)

Ah, I had the branch discussion put under "for different platform", not for different config. For changing the config in only the number of domains, I'd propose for the CI job to edit the *_verified.config files (via regexp) before it starts the test. That should be pretty targeted and test the entire chain.

@Xaphiosis
Copy link
Member

Search+replace via regexp sounds like a good plan and will catch other arches should they appear.
Yes, you're right, I'm conflating discussions. You proposed the floating commit for a platform port. My bad.

@lsf37
Copy link
Member Author

lsf37 commented Feb 10, 2024

This has been implemented in #701 and related PRs.

@lsf37 lsf37 closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration and testing
Projects
None yet
Development

No branches or pull requests

2 participants