Problem: hax depends on LD_LIBRARY_PATH

[typeundefined]

Currently our scripts start hax with LD_LIBRARY_PATH environment variable set — we use it to tell the linker where to look for libmero.so. This approach is considered harmful.

Solution:

• modify Makefile: set -Wl,-rpath=$M0_SRC_DIR/mero/.libs as described in Program Library HOWTO (and here)
• remove LD_LIBRARY_PATH from the code

[vvv]

changed the description

[vvv]

changed title from {-Makefile issue: hax requires LD_LIBRARY_PATH set to link with libmero-} to {+Problem: hax requires LD_LIBRARY_PATH to be set+}

[vvv]

changed title from Problem: hax {-requires LD_LIBRARY_PATH to be set-} to Problem: hax {+depends on LD_LIBRARY_PATH+}

[vvv]

assigned to @konstantin.nekrasov

[vvv]

I'd suggest that we merge #112 before making any other changes to the Makefile.

[vvv]

changed the description

[typeundefined]

The is issue is already resolved by the latest setup.py. Hax doesn't depend on LD_LIBRARY_PATH anymore.
@vvv is there anything else I can do to resolve this ticket? Maybe you'd also like have Makefile removed?

[chumakd]

Example of Python's setuptools usage for packaging and running commands from source tree: https://github.com/seagate-ssg/pyghmi

def main():
    # blah-blah-...

if __name__ == '__main__':
    sys.exit(main())

[vvv]

Hax doesn't depend on LD_LIBRARY_PATH anymore. @vvv is there anything else I can do to resolve this ticket?

@konstantin.nekrasov git-grep shows the last hideout of LD_LIBRARY_PATH:

$ git grep -nH -A1 LD_LIBRARY_PATH
start:42:sudo LD_LIBRARY_PATH=$M0_SRC_DIR/mero/.libs/ $SRC_DIR/env/bin/python \
start-43-     $SRC_DIR/hax/hax.py

We can close this issue after cleansing the repo of LD_LIBRARY_PATH. 🚿

@andriy.tkachuk Is start script used at all?

If start script is obsolete, it should removed.

[andriytk]

No, it's not used. install and bootstrap scripts seem to be enough atm.

[vvv]

mentioned in merge request #186

[vvv]

closed via commit 33e1ffe

[typeundefined]

closed via merge request #186