Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatGraph does not support offset collapsing #84

Closed
agurfinkel opened this issue Jun 9, 2020 · 1 comment
Closed

FlatGraph does not support offset collapsing #84

agurfinkel opened this issue Jun 9, 2020 · 1 comment
Assignees
@caballa

Comments

@agurfinkel
Copy link
Contributor

Under FlatGraph, there is only one dsa node. (i.e., mkNode() always returns the same object).

However, Node::collapseOffsets() calls Node::pointTo, and pointTo requires two distinct nodes. Thus every attempt to call collapseOffsets with FlatGraph causes an assertion failure.
@agurfinkel
Copy link
Contributor Author

fixed by 405f2f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caballa caballa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caballa @agurfinkel