Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied overlay z-index too low #3

Closed
pqt opened this issue Feb 2, 2016 · 6 comments
Closed

Applied overlay z-index too low #3

pqt opened this issue Feb 2, 2016 · 6 comments

Comments

@pqt
Copy link
Contributor

pqt commented Feb 2, 2016

I think the z-index should be ~1500 to start off. The one in bootstrap is 1040.

I have a z-index of 180 on a relatively positioned navigation bar (becomes fixed with 200 z-index later on) and it overlays the background.

It doesn't necessarily need to be that high, but 0 is most likely insufficient in a lot of cases.

With 1500 it does as expected (although it may be a little large of a number respectively)

@seahorsepip
Copy link
Owner

Strange, z-index should start at 1000 by default. I'll look into it.

@seahorsepip
Copy link
Owner

*start at 10000

@seahorsepip
Copy link
Owner

I think it might be a bug I introduced after changing show() into fadeIn() at setOverlay() in the last update. Probably removed the z-index code by accident.

@seahorsepip
Copy link
Owner

Issue has been resolved with last update.

@pqt
Copy link
Contributor Author

pqt commented Feb 3, 2016

@seahorsepip when you commit and it fixes an issue you can add "closes #3" to the commit message (or title) and it will automatically close this.

@seahorsepip
Copy link
Owner

Ah great, learned something new today 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants