Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't get into a --max-snapshots infinite loop #41

Open
seanh opened this issue Mar 20, 2016 · 0 comments
Open

Don't get into a --max-snapshots infinite loop #41

seanh opened this issue Mar 20, 2016 · 0 comments

Comments

@seanh
Copy link
Owner

seanh commented Mar 20, 2016

When --max-snapshots is used and _remove_oldest_snapshot() doesn't actually reduce the number of snapshots reported to _ls_snapshots() (for example when --dry-run is used so that we don't actually run the rm command) then snapshotter gets into an infinite loop as it keeps calling _remove_oldest_snapshot() until _ls_snapshots() reports less than --max-snapshots snapshots, but _ls_snapshots() always reports the same number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant