Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_SC_NPROCESSORS_CONF doesn't exist on Android #46

Closed
CryZe opened this issue Jun 23, 2017 · 3 comments
Closed

_SC_NPROCESSORS_CONF doesn't exist on Android #46

CryZe opened this issue Jun 23, 2017 · 3 comments

Comments

@CryZe
Copy link

CryZe commented Jun 23, 2017

num_cpus 1.6.1 broke semver on Android as _SC_NPROCESSORS_CONF doesn't exist on those platforms.

You can see it missing here: https://github.com/rust-lang/libc/blob/master/src/unix/notbsd/android/mod.rs#L257

So #45 needs to be partially reverted and 1.6.1 possibly yanked.

@kubo39
Copy link
Contributor

kubo39 commented Jun 23, 2017

It does not exist on the libc crate side.

@seanmonstar
Copy link
Owner

I was worried about this. So many cfg(target_os ...), but don't currently have a way to test all the OSes. Funny though, that this was meant to actually fix Android, not break it.

@seanmonstar
Copy link
Owner

Reverted, 1.6.2 published, 1.6.1 yanked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants