can't log in with DSM 4.2

[hoyeung3407]

Versions

Extension version: 0.30 or 0.31, last updated 2017-11-15
Browser and version: Firefox 56.0 (64 bit)
DSM version: 4.2-3256
Download Station version: 3.3-2386

Steps to Reproduce the Issue

It just stop working some days ago,
today i open the settings page and click the "Test Connection" button,
then it shows "The requested version does not support this functionality."

Please bring back support for old DSM in future versions, thank you.

[seansfkelley]

Oh boy. Given that this happens with "test connection", this must have been caused by the fix to #32, which increased the API version used for logging in to prevent it from overriding the browser's session cookies.

It seems reasonable to reintroduce this to support old versions, with a caveat. I'm thinking:

• synology-typescript-api should accept a version parameter for the API calls
• The extension should check if the NAS supports a sufficient version of the auth API. If it does, change nothing. If it doesn't, drop down to using the old API version but warn the user (probably with a link to Log in with different cookie than normal browser user? #32).

Auditing synology-typescript-api for usages of version !== 1 will likely help prevent these issues in the future.

[hoyeung3407]

It seems to be the solution, hope it is acceptable for other users too.
Thank you very much !

[seansfkelley]

@hoyeung3407 in the mean time, you can use version 0.2.1 which shouldn't have this issue (though also with fewer features). I'm hoping to get a fix out in the next couple days!

[hoyeung3407]

Oh, you're very helpful. Thank you.

[seansfkelley]

Should be fixed by 6df62e8.

[hoyeung3407]

You're a lifesaver !
Updated to version 0.4.1 and it works again.
Very quick response and update, thank you !

[seansfkelley]

Yay! Thanks for verifying for me.